Java coding style 注意事項

1
2
3

private String fyr = StringUtils.EMPTY;
        // v.s. //
private String fyr = ""; // better

if (!StringUtils.equals("G3", toPos)) {...}
        // v.s. //
if (!Objects.equals("G3", toPos)) {...}
        // v.s. //
if ("G3".equals(toPos)) {...} // better

List<Cta612pDto> cta612Dtos = sqlExecutor
        .queryForList(query, Cta612pDto.class);
if (CollectionUtils.isNotEmpty(cta612Dtos)) {...}

             // v.s. //

List<Cta612pDto> cta612Dtos = sqlExecutor
        .queryForList(query, Cta612pDto.class);
if (!cta612Dtos.isEmpty()) {...} // better

1
2
3

private BigDecimal pAmt = new BigDecimal(0);
        // v.s. //
private BigDecimal pAmt = BigDecimal.ZERO; // better

if (Arrays.asList(new String[] {"20", "21"})
    .contains(pAge)) {...} 
                     // v.s. //
private static final Set<String> VALID_P_AGES =
    ImmutableSet.of("20", "21");    
if (VALID_P_AGES.contains(pAge)) {...} // better

請做 local variable …


page = list.get(i).getAge();
pacc = list.get(i).getAcc();
pasp = list.get(i).getAsp();
pagency = list.get(i).getAgency();
if (StringUtils.isNotBlank(list.get(i).getName())
        && StringUtils.equals("Z0", list.get(i).getAsp())) {
    pname = "追加減預算";
} else {
    pname = list.get(i).getName();
}
paccalt = list.get(i).getAccalt();
pypay = list.get(i).getYpay();
pctl = list.get(i).getCtl();
pdispos = list.get(i).getDispos();